Danenbm/collapse registry record struct

[danenbm]

Removed the pub data: RegistryData, in both RegistryRecord and ExternalPluginRecord since it doesn't seem to be helping us. Also simplified the iterators from destructuring in the closure to just dereferencing when using.

So combining the two changes simplifies our usage a bit:

let plugin_data = registry
        .iter()
        .find(
            |RegistryRecord {
                 plugin_type: plugin_type_iter,
                 data: _,
             }| *plugin_type_iter == plugin_type,
        )
        .map(
            |RegistryRecord {
                 plugin_type: _,
                 data,
             }| data,
        )
        .ok_or(MplCoreError::PluginNotFound)?;

becomes

let plugin = registry
        .iter()
        .find(|record| record.plugin_type == plugin_type)
        .ok_or(MplCoreError::PluginNotFound)?;

[danenbm]

This size increase used to be just a RegistryData, but I think it should have been a full RegistryRecord because we are adding a new RegistryRecord to the Vec. Could you double-check this math?

[blockiosaurus]

I think you're right.