fix: don't crash but gracefully ignore undefined for wildcard keypaths

metalsmith · Feb 26, 2023 · d05e39a · d05e39a
1 parent 53feb48
commit d05e39a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 1 deletion.
diff --git a/src/expand-wildcard-keypath.js b/src/expand-wildcard-keypath.js
@@ -48,6 +48,8 @@ function expandWildcardKeypath(root, keypaths, char) {
     if (wildcard > -1) {
       const pre = keypath.slice(0, wildcard)
       const wildcardRoot = get(root, pre)
+
+      if (!wildcardRoot) return result
       const looped = isArray(wildcardRoot) ? wildcardRoot : Object.keys(wildcardRoot)
 
       looped.forEach((entry, index) => {

diff --git a/src/index.js b/src/index.js
@@ -112,7 +112,7 @@ function markdown(options = defaultOptions) {
           set(data, key, options.render(globalRefsMarkdown + value, options.engineOptions, { path: file, key }))
           // log a warning if the key is defined and of an unexpected type, but not if the property simply is not defined
         } else if (typeof value !== 'undefined') {
-          debug.warn('Couldn\'t render key %s of file "%s": not a string', key.join ? key.join('.') : key, file)
+          debug.warn('Couldn\'t render key "%s" of file "%s": not a string', key.join ? key.join('.') : key, file)
         }
       })
 

diff --git a/test/fixtures/array-index-keys/src/empty.md b/test/fixtures/array-index-keys/src/empty.md
diff --git a/test/fixtures/nested-keys/src/empty.md b/test/fixtures/nested-keys/src/empty.md