🌱 Add scalability test prow triggers #953
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -200,3 +200,10 @@ presubmits: | |||
| agent: jenkins | |||
| always_run: false | |||
| optional: true | |||
| # name: metal3-centos-e2e-feature-test-release-1-9-scalability | |||
There was a problem hiding this comment.
Imo they're still useful as separation.
There was a problem hiding this comment.
In release branch config they seem removed altogether.
They're supposed to show the template format, like they do in main config.
There was a problem hiding this comment.
That's not something we have agreed on. We started adding those comments back when the prow config grows so big and unorganized, so the point of having them is just so that we can tell apart which from which, we didn't discussed the "rules" of where they should be and how they should look like/
Since you insist I'll remove these comments now, but IMO adding the comments here really help making the separation easier to follow.
There was a problem hiding this comment.
Convention is form of agreement as well.
Zero information comments are worth nothing, they're actually worth negative since they need to be maintained not to be outdated.
If you want to use separator, use empty line.
|
/test metal3-ubuntu-e2e-integration-test-main |
|
/retest |
1 similar comment
|
/retest |
This commit adds the new scalability tests to prow Signed-off-by: Huy Mai <huy.mai@est.tech>
fd0e385 to
358e71a
Compare
|
/test metal3-ubuntu-e2e-integration-test-main |
1 similar comment
|
/test metal3-ubuntu-e2e-integration-test-main |
|
/unhold |
|
@mquhuy: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This commit adds the new scalability tests to prow