Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backend Gnosis proposalsURI. #108

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

crazyyuan
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for whimsical-cuchufli-3a5565 canceled.

Name Link
🔨 Latest commit 867798b
🔍 Latest deploy log https://app.netlify.com/sites/whimsical-cuchufli-3a5565/deploys/64d3b6299d126100089046ba

@thelastjosh
Copy link
Member

Looks good / reasonable, would be helpful if you could give a quick example of the new version that's generated through this pointing out the additional stuff.

@crazyyuan
Copy link
Collaborator Author

@thelastjosh
Copy link
Member

Okay, some comments on the link:

  • first, DAO "name" should not be the contract address, it should be the actual name of the DAO, or empty.
  • the "id" format does not follow the stated format for id in EIP-4824. I've copied the relevant section below.

In particular, any on-chain proposal MUST be associated to an id of the form CAIP10_ADDRESS + “?proposalId=” + PROPOSAL_COUNTER, where CAIP10_ADDRESS is an address following the CAIP-10 standard and PROPOSAL_COUNTER is an arbitrary identifier such as a uint256 counter or a hash that is locally unique per CAIP-10 address. Off-chain proposals MAY use a similar id format where CAIP10_ADDRESS is replaced with an appropriate URI or URL.

{
"@context": "http://www.daostar.org/schemas",
"type": "DAO",
"name": "",
"proposals": [
{
"type": "proposal",
"id": "",
"name": "",
"contentURI": "",
"status": "",
"calls": [
{
"type": "CallDataEVM",
"operation": "",
"from": "",
"to": "",
"value": "",
"data": ""
}
]
}
]
}

@crazyyuan
Copy link
Collaborator Author

Okay, some comments on the link:

  • first, DAO "name" should not be the contract address, it should be the actual name of the DAO, or empty.
  • the "id" format does not follow the stated format for id in EIP-4824. I've copied the relevant section below.

In particular, any on-chain proposal MUST be associated to an id of the form CAIP10_ADDRESS + “?proposalId=” + PROPOSAL_COUNTER, where CAIP10_ADDRESS is an address following the CAIP-10 standard and PROPOSAL_COUNTER is an arbitrary identifier such as a uint256 counter or a hash that is locally unique per CAIP-10 address. Off-chain proposals MAY use a similar id format where CAIP10_ADDRESS is replaced with an appropriate URI or URL.

{ "@context": "http://www.daostar.org/schemas", "type": "DAO", "name": "", "proposals": [ { "type": "proposal", "id": "", "name": "", "contentURI": "", "status": "", "calls": [ { "type": "CallDataEVM", "operation": "", "from": "", "to": "", "value": "", "data": "" } ] } ] }

Got it, I'll document this and create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants