Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some general tidy up #80
Some general tidy up #80
Changes from 1 commit
eb2d614
c2588bb
e44e3c3
2395e25
ace6458
4707499
851c7f7
e6bbbc6
0a60145
0b58ce6
5a29061
b56ddaf
0b013de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? :( I mean, dashes are ok, but I really don't like this obsession with it being a replacement for everything somehow. https://thenarrativearc.org/blog/2020/2/4/epic-grammar-battle-semicolon-versus-em-dash for example. Sometimes text just flows better with a colon or a semicolon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short sentences are always better, particularly for people who might be reading in a second language, or have other reading difficulties. Though I am a chronic long sentencer-er... I try and keep myself in check. So I think it's a good reminder that a colon/dash could often just be two sentences instead. I stand behind that bit.
Otherwise I don't think it's about never using a colon or a semi colon, just being consistent when you are choosing between the two. We could easily swap this to be 'avoid dashes'?
For me it is quite noticeable if someone is writing with a lot of dashes - it's pretty distinct - or if they're using a lot of semicolons; also very distinct. So either way it's nice to offer guidance if someone is wondering which to go with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, trying to have shorter sentences is not a bad idea. Maybe this should be "Colons, semicolons and dashes": "If it makes sense, write two shorter sentences rather than using these" then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to gently encourage one of these three over the others 'colons, semicolons and dashes'.
Not because I hate any of them, but for consistency across different authors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was taught that em dashes are for interruptions of thought, not a replacement for the semicolon, though I suppose it's a matter of style. :) If I'm presenting a list of items, I'd usually use a colon. (As this document does several times.)
This part I agree with: "when possible we’ll write 2 sentences instead." But I'm not sure I'd encourage dashes as a catch-all replacement for colons and semicolons. I'd just say to avoid all three unless two separate sentences sounds clunky. (That's probably not often.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In French, dashes are apposition, that can also be written with (round) parenthesis or even with comma (but it's more oral style, then).
It is very different from colons and semi-colons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just always use double quotation marks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you write "technical term" with double guotes I assume you're quoting a line from someone else or from a specific source, which wouldn't be the case with these. Perhaps that's just what I learnt in school? But that makes sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I guess my idea was "drop those two, use double quotes for titles". But if single quotes for that is a generally accepted convention, then fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I was taught to use single quotation marks for quotes-inside-quotes, but I don't remember them having special meaning otherwise. Is there an existing style guide that recommends this usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if it's "you have two options" or "you can pick up to three"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was very curious about this too! I always learned to write out the number in words up until... 8? or 10?
I do like the point here about helping to scan content. Makes it very easy to pick out numbers in a paragraph if you're looking for them. But happy to replace with 'use words up until x, then use numbers', if you think that's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "use words from 0-9" and "use digits for 10 and up" seems reasonable. I learned something similar (though I don't remember the exact cutoff). One situation where I think digits look odd (especially for small numbers) is at the beginning of a sentence: "Two options are available." vs. "2 options are available."