Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Dependencies and Fix Configurations #38

Merged
merged 11 commits into from
Jan 23, 2022
Merged

Bumped Dependencies and Fix Configurations #38

merged 11 commits into from
Jan 23, 2022

Conversation

akshaaatt
Copy link
Member

  • The project needs to be bumped before we add major changes.

@akshaaatt akshaaatt requested a review from mwiencek September 22, 2021 16:45
@mwiencek
Copy link
Member

Did you test running the project with the new dependencies? (Not sure if the Webpack upgrade in particular requires changes.)

@akshaaatt akshaaatt changed the title Bumped dependencies Bumped Decencies and Fix Configurations Jan 23, 2022
@akshaaatt akshaaatt changed the title Bumped Decencies and Fix Configurations Bumped Dependencies and Fix Configurations Jan 23, 2022
@akshaaatt
Copy link
Member Author

Finally verified and all working!
Preview available at https://61ec89ab79aea5003a4ece24-kskqlfpzms.chromatic.com

@akshaaatt akshaaatt merged commit 97c975d into metabrainz:master Jan 23, 2022
@akshaaatt akshaaatt deleted the dev-updates branch January 23, 2022 23:09
@mwiencek
Copy link
Member

Thanks! For the future, try to make your commit messages more descriptive, or squash them together if they were WIP and constitute a single change in the end. For example, 0174a05 has a commit message explaining why some lines of scss/bootstrap-prod.scss were commented out. Some of the commits here changed that and then reverted the changes, but there's no explanation other than "cleanup" and "fix."

There are also a lot of unrelated changes in each commit here. Ideally each commit should do one thing. That makes it much easier for other team members to review and use tools like git bisect and git blame in the future. This has some good tips: https://reflectoring.io/meaningful-commit-messages/

@akshaaatt
Copy link
Member Author

Makes sense. Will do so in future!👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants