-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped Dependencies and Fix Configurations #38
Conversation
akshaaatt
commented
Sep 19, 2021
- The project needs to be bumped before we add major changes.
Did you test running the project with the new dependencies? (Not sure if the Webpack upgrade in particular requires changes.) |
…into dev-updates
…into dev-updates
- Code cleanup
Finally verified and all working! |
Thanks! For the future, try to make your commit messages more descriptive, or squash them together if they were WIP and constitute a single change in the end. For example, 0174a05 has a commit message explaining why some lines of scss/bootstrap-prod.scss were commented out. Some of the commits here changed that and then reverted the changes, but there's no explanation other than "cleanup" and "fix." There are also a lot of unrelated changes in each commit here. Ideally each commit should do one thing. That makes it much easier for other team members to review and use tools like |
Makes sense. Will do so in future!👌 |