Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies + fixes #102

Merged
merged 3 commits into from
Apr 29, 2023
Merged

Conversation

santiagofn
Copy link
Contributor

@santiagofn santiagofn commented Apr 29, 2023

  • Removed file-loader & url-loader and replaced them with webpack5 asset (https://webpack.js.org/guides/asset-modules/)
  • Removed react-bootstrap-table-next (no longer maintained), now using react-bootstrap/Table
  • Bump style-loader, postcss-loader, css-loader
  • Fixed bootstrap generic CSS creation

@santiagofn santiagofn marked this pull request as ready for review April 29, 2023 06:52
- Removed file-loader & url-loader and replaced them with
  webpack5 asset (https://webpack.js.org/guides/asset-modules/)
- Removed react-bootstrap-table-next (no longer maintained), now
  using react-bootstrap/Table
- Bump style-loader, postcss-loader, css-loader
- Fixed bootstrap generic CSS creation
Copy link
Member

@akshaaatt akshaaatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates! 💯

package.json Outdated Show resolved Hide resolved
components/shared/Table.js Show resolved Hide resolved
@santiagofn santiagofn requested a review from akshaaatt April 29, 2023 07:54
Copy link
Member

@akshaaatt akshaaatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@akshaaatt akshaaatt merged commit 1ed677c into metabrainz:master Apr 29, 2023
@santiagofn santiagofn deleted the bump-and-fixes branch April 29, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants