Add Pagination Component #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
Jul 10, 2018
| <Pagination.Item>{11}</Pagination.Item> | ||
| <Pagination.Item active>{12}</Pagination.Item> | ||
| <Pagination.Item>{13}</Pagination.Item> | ||
| <Pagination.Item disabled>{14}</Pagination.Item> |
There was a problem hiding this comment.
One potential issue I saw is that the text color of the disabled one is darker (or has a higher perceptible value) than the non-disabled ones, so it stood out more and didn't register as "disabled" to me.
There was a problem hiding this comment.
In the dropdown PR you use a lighter shade of purple for the disabled button text. Perhaps the same should be used here?
|
Adding a fill like drop-down was making it even more prominent. How do you like this one? |
|
Looks better 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR to add pagination :D Let me know if this works!