-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic directories #1
Conversation
One question: what sort of stuff will the layout/ directory contain? (I thought it might be layout-related components, but those could also make sense under components/, so I was unsure.) |
Hi, basically what I mean by layout is grids here. You can see an example here: I named it layout because I was planning to add layouts/card arrangement for all screen sizes. Things like, "the cards on the side panel on a desktop, go here for small mobile devices". No code, mostly images/specifications. Does it make sense? |
Yes, that makes sense. Thanks! |
guidelines/contributing.md
Outdated
@@ -0,0 +1 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of guidelines
folder name, please use docs
or .github
so as to follow paths referred by GitHub: https://github.com/metabrainz/design-system/community
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would normally not add a bunch of blank files, but I think you have a plan for these, so don't let me stand in your way. :) 🌮 🍜 🍕
Hi, just added a basic framework for the design system here. The structure is very similar to what we discussed earlier here,
https://gist.github.com/chhavijustme/8447c9a57cd743e8deb214f449724125
I have divided the assets folder into two: style and components.
Style will have color, fonts, icons, and layout.