Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic directories #1

Merged
merged 7 commits into from
May 7, 2018
Merged

Conversation

chhavijustme
Copy link
Contributor

Hi, just added a basic framework for the design system here. The structure is very similar to what we discussed earlier here,
https://gist.github.com/chhavijustme/8447c9a57cd743e8deb214f449724125

I have divided the assets folder into two: style and components.
Style will have color, fonts, icons, and layout.

@mwiencek
Copy link
Member

One question: what sort of stuff will the layout/ directory contain? (I thought it might be layout-related components, but those could also make sense under components/, so I was unsure.)

@chhavijustme
Copy link
Contributor Author

Hi, basically what I mean by layout is grids here. You can see an example here:
http://carbondesignsystem.com/style/grid/design

I named it layout because I was planning to add layouts/card arrangement for all screen sizes. Things like, "the cards on the side panel on a desktop, go here for small mobile devices". No code, mostly images/specifications. Does it make sense?

@mwiencek
Copy link
Member

Yes, that makes sense. Thanks!

@@ -0,0 +1 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of guidelines folder name, please use docs or .github so as to follow paths referred by GitHub: https://github.com/metabrainz/design-system/community

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would normally not add a bunch of blank files, but I think you have a plan for these, so don't let me stand in your way. :) 🌮 🍜 🍕

@mwiencek mwiencek merged commit 1fab08e into metabrainz:master May 7, 2018
@chhavijustme chhavijustme deleted the adds-folders branch June 6, 2018 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants