This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
hide link previews when a status is hidden behind a content warning (fixes issue #95) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzzocc
pushed a commit
that referenced
this pull request
Nov 10, 2022
jzzocc
pushed a commit
that referenced
this pull request
Nov 10, 2022
|
As mentioned in #58, this doesn't fix the issue. |
|
that's.... really weird. i can indeed confirm that the latest app store version still has the problem -- but when i take the latest code and run it on the iphone simulator on my computer, the fix works perfectly! i can't seem to debug the latest code on an actual device, though (getting some errors that i'm not sure how to fix; would love some help if anyone has the time and know-how!) so i can't rule out that there may be some weird bug-within-a-bug that only happens on real devices? |
|
I suppose it's possible the app store build isn't actually up to date... but that's pure speculation. I've never personally shipped anything to the app store. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hi! this seemed like an extremely easy fix, so i thought i'd give it a shot 😅 i hope i didn't miss anything lol!
screenshots of what the fix looks like:
fixes issue #95
Other Information