Use user-visible adapter name on Windows #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Keep the old GUID, but as its own field, as it's still useful in some contexts.
I would parse the GUID, but the WinAPI docs don't say anything about the string's format, so we can't trust that my system's values are formatted like anyone else.
Note: this is a BREAKING CHANGE if anyone was relying on the
name
struct member being the GUID. I think this is a good change to make, but if a release is pushed it'll need a semver bump.Example interface after this change: