Add Ubuntu Based DIND Agent #11
Conversation
Add a docker-in-docker agent based on Ubuntu. This provides a typical glibc environment, whereas alpine uses musl.
|
retest this please |
|
Please rename |
Now that there are multiple images available, rename Dockerfile to Dockerfile.alpine. This matches the naming style of Dockerfile.ubuntu.
| lvm2 \ | ||
| lxc \ | ||
| openjdk-8-jre-headless \ | ||
| unzip \ |
There was a problem hiding this comment.
nit: can these \s be aligned?
|
Is there a build script or build script changes that can be committed as part of this PR as well? |
|
@rji - there are no build scripts currently in this repo. Would you suggest a script that builds everything, a script per image, or an update to the README with build instructions? |
|
A single script that builds everything. |
Add a script to build all Docker images. This script leverages git to create the tag name. Added a .dockerignore file to prevent scripts from being considered in the docker build context.
Remove commented out code.
| jq \ | ||
| lvm2 \ | ||
| lxc \ | ||
| openjdk-8-jre-headless \ |
|
Could we make the script also do a |
|
I am adding a |
|
Good point, that sounds good to me. Thanks @colin-msphere! |
|
Looking at the build script and how it's tagging and pushing images, this appears to tag the images using a convention like I'm not sure that we can safely abandon our previous versioning scheme since it could lead to inconsistencies in users' environments (for example: using an older, cached image on one machine and pulling down a newer version on a machine where the image isn't already cached). I also don't think it's wise to recommend that users force pull this image every time a CI build needs to take place. |
Allow the tag prefix to be passed in as a third parameter.
Add a docker-in-docker agent based on Ubuntu. This provides a typical glibc environment, whereas alpine uses musl.