Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os.path.normpath() for include paths #6782

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Use os.path.normpath() for include paths #6782

merged 2 commits into from
Mar 19, 2020

Conversation

ClausKlein
Copy link
Contributor

This make relative pathes shorter an too give a chance to
de-duplicate -isystem flags just like -I flags.

Fix common test case 203 for OSX build host too.

Related to #2155

@ClausKlein
Use os.path.normpath() for include paths
5f7e08a 
This make relative pathes shorter an too give a chance to
de-duplicate -isystem flags just like -I flags.

Fix common test case 203 for OSX build host too
@ClausKlein ClausKlein requested a review from jpakkane as a code owner March 13, 2020 07:50
@ClausKlein
Copy link
Contributor Author

see too the ninja-build/ninja#1251 (comment)

jpakkane
jpakkane requested changes Mar 17, 2020
View reviewed changes
mesonbuild/mesonlib.py Outdated Show resolved Hide resolved
test cases/common/203 function attributes/meson.build Show resolved Hide resolved
mesonbuild/backend/ninjabackend.py Show resolved Hide resolved
dcbaker
dcbaker requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, it also may fix some cases of "too long command line", but I do have a single change in four cases.

mesonbuild/backend/ninjabackend.py Outdated Show resolved Hide resolved
@ClausKlein
Remove my notes from sources
2d61629 
changes acording review comments
@jpakkane jpakkane merged commit 00104b1 into mesonbuild:master Mar 19, 2020
@jpakkane
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpakkane jpakkane jpakkane requested changes

@dcbaker dcbaker dcbaker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ClausKlein @jpakkane @dcbaker