Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome: add support for update-mime-database #10867

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

pbor
Copy link
Contributor

@pbor pbor commented Sep 28, 2022

Fixes #10865

@pbor pbor requested a review from jpakkane as a code owner September 28, 2022 12:43
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #10867 (82c6695) into master (56a6ee1) will decrease coverage by 1.68%.
The diff coverage is n/a.

❗ Current head 82c6695 differs from pull request most recent head 426068f. Consider uploading reports for the commit 426068f to get more accurate results

@@            Coverage Diff             @@
##           master   #10867      +/-   ##
==========================================
- Coverage   68.45%   66.76%   -1.69%     
==========================================
  Files         404      203     -201     
  Lines       86697    44365   -42332     
  Branches    19207     9830    -9377     
==========================================
- Hits        59347    29620   -29727     
+ Misses      22891    12502   -10389     
+ Partials     4459     2243    -2216     
Impacted Files Coverage Δ
scripts/run_tool.py 0.00% <0.00%> (-100.00%) ⬇️
scripts/clangtidy.py 0.00% <0.00%> (-93.34%) ⬇️
modules/cuda.py 0.00% <0.00%> (-72.64%) ⬇️
templates/cudatemplates.py 37.50% <0.00%> (-62.50%) ⬇️
scripts/clangformat.py 0.00% <0.00%> (-54.84%) ⬇️
compilers/cuda.py 19.63% <0.00%> (-45.40%) ⬇️
dependencies/cuda.py 20.19% <0.00%> (-42.79%) ⬇️
compilers/d.py 38.39% <0.00%> (-18.47%) ⬇️
compilers/mixins/clang.py 56.09% <0.00%> (-14.64%) ⬇️
scripts/coverage.py 51.48% <0.00%> (-12.88%) ⬇️
... and 224 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xclaesse
Copy link
Member

xclaesse commented Sep 28, 2022

Technically update-mime-database is a freedesktop thing and not gnome, but so is desktop-file-utils we already have. I don't think it's worth splitting this functionality.

LGTM, but please add a release snippet.

@eli-schwartz
Copy link
Member

eli-schwartz commented Sep 28, 2022

Considering skip_if_destdir exists and it's pretty easy to do this in a single line with add_install_script I wonder how much sense it makes to keep adding non-gnome things to the gnome module (it doesn't even have the possibility of having multiple names to run the command, as the icon cache program does).

Granted this is fairly common... idk.

@xclaesse
Copy link
Member

@eli-schwartz one reason I like to wrap those common tools is because if at some point we need to change how we search it, we can do it in Meson instead of patching thousands projects. That's the case for example if the tool path gets added in a pkgconfig file, or gets renamed like they did for gtk4, etc. Granted it's pretty unlikely in this case, but who knows...

@xclaesse
Copy link
Member

Ah, also this PR means we update the db only once, instead of once per subproject.

@xclaesse
Copy link
Member

macos CI failed but that seems unrelated. LGTM.

@xclaesse xclaesse merged commit a58ec32 into mesonbuild:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gnome.post_install does not support update-mime-database
3 participants