-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome: add support for update-mime-database #10867
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10867 +/- ##
==========================================
- Coverage 68.45% 66.76% -1.69%
==========================================
Files 404 203 -201
Lines 86697 44365 -42332
Branches 19207 9830 -9377
==========================================
- Hits 59347 29620 -29727
+ Misses 22891 12502 -10389
+ Partials 4459 2243 -2216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Technically LGTM, but please add a release snippet. |
Considering skip_if_destdir exists and it's pretty easy to do this in a single line with add_install_script I wonder how much sense it makes to keep adding non-gnome things to the gnome module (it doesn't even have the possibility of having multiple names to run the command, as the icon cache program does). Granted this is fairly common... idk. |
@eli-schwartz one reason I like to wrap those common tools is because if at some point we need to change how we search it, we can do it in Meson instead of patching thousands projects. That's the case for example if the tool path gets added in a pkgconfig file, or gets renamed like they did for gtk4, etc. Granted it's pretty unlikely in this case, but who knows... |
Ah, also this PR means we update the db only once, instead of once per subproject. |
macos CI failed but that seems unrelated. LGTM. |
Fixes #10865