Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add processing on discovery of resources #289

Merged
merged 4 commits into from
Dec 26, 2023

Conversation

MUzairS15
Copy link

@MUzairS15 MUzairS15 commented Dec 25, 2023

Description

This PR adds functionality to perform processing on discovered resources before publishing them to the Meshery Server.
The processing is performed on K8S services to extract and store service endpoints.
The changes ensure that Meshery Server and other clients do not need to perform the heavy lifting but the MeshSync controller performs its jobs to its fullest.

To add more processors, we just need to implement ProcessFunc interface.
Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

MUzairS15 added 3 commits December 25, 2023 23:17
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c0a7f1) 9.65% compared to head (92fbd5b) 9.65%.

Files Patch % Lines
meshsync/handlers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #289   +/-   ##
======================================
  Coverage    9.65%   9.65%           
======================================
  Files          10      10           
  Lines         632     632           
======================================
  Hits           61      61           
  Misses        564     564           
  Partials        7       7           
Flag Coverage Δ
unittests 9.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MUzairS15 MUzairS15 merged commit 2d4671c into master Dec 26, 2023
5 of 6 checks passed
@MUzairS15 MUzairS15 deleted the MUzairS15/feat/fingerprinting/2 branch December 26, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant