Skip to content

Commit

Permalink
Merge pull request #349 from devhindo/go23
Browse files Browse the repository at this point in the history
Bump `meshsync` Go version to 1.23 in workflows, Dockerfile, and go.mod
  • Loading branch information
leecalcote authored Dec 27, 2024
2 parents bd31b73 + 6d5ef10 commit 5e7b75a
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-and-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@main
with:
go-version: '1.21'
go-version: '1.23'
check-latest: 'true'
- run: GOPROXY=direct GOSUMDB=off GO111MODULE=on go build -o meshery-meshsync .
docker:
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Setup go
uses: actions/setup-go@main
with:
go-version: '1.21'
go-version: '1.23'
check-latest: 'true'
- name: Docker login
uses: docker/login-action@v2
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
platform: [ubuntu-22.04]
go-version: [1.21.x]
go-version: [1.23.x]
runs-on: ${{ matrix.platform }}
steps:
- name: Check out code
Expand All @@ -36,7 +36,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: '1.21.x'
go-version: '1.23.x'
- name: Run unit tests
run: go test --short ./... -race -coverprofile=coverage.txt -covermode=atomic
- name: Upload coverage to Codecov
Expand All @@ -55,6 +55,6 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: '1.21.x'
go-version: '1.23.x'
- name: Build
run: make build
2 changes: 1 addition & 1 deletion .github/workflows/error-codes-updater.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@main
with:
go-version: ${{ secrets.GO_VERSION }}
go-version: '1.23'

- name: Run utility
run: |
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.21 as builder
FROM golang:1.23 as builder
ARG GIT_VERSION
ARG GIT_COMMITSHA

Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ replace (
vbom.ml/util => github.com/fvbommel/util v0.0.0-20180919145318-efcd4e0f9787
)

go 1.21
go 1.23

toolchain go1.21.1
toolchain go1.23.4

require (
github.com/buger/jsonparser v1.1.1
Expand Down

0 comments on commit 5e7b75a

Please sign in to comment.