-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing Model Filter Get Method #687
base: master
Are you sure you want to change the base?
Optimizing Model Filter Get Method #687
Conversation
Signed-off-by: Souvik Kar Mahapatra <souvikat001@gmail.com>
Signed-off-by: Souvik Kar Mahapatra <souvikat001@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you please describe where this function is being used and how this bulk behavior improves performance? |
Yes, I'll do benchmarking and share it here. |
@souvikinator that's not what I'm asking for. What other parts of Meshery use this functionality? How have you confirmed that you've not broken those areas with this change? What is driving this change? Is there an open issue describing this or calling for this PR? |
@leecalcote I went through all the occurrences of this Went to each part in the dashboard where these are being called and compared it to the playground in the production. |
Description
This PR fixes #
Notes for Reviewers
Before:
After:
Signed commits