Add errors to enhance model import error logging #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Signed-off-by: Riya Garg <riyag1452003@gmail.com>
Signed-off-by: Riya Garg <riyag1452003@gmail.com>
Signed-off-by: Riya Garg <riyag1452003@gmail.com>
3b69606 to
c30c5a9
Compare
| @@ -32,9 +32,9 @@ var ValidIacExtensions = map[string]bool{ | |||
| ".tar": true, | |||
| ".tar.gz": true, | |||
| ".tar.tgz": true, | |||
| ".zip": true, | |||
There was a problem hiding this comment.
why are we removing zip files?
There was a problem hiding this comment.
I noticed that zip isn't working for both designs and models, this can confuse the user if we say zip is supported. I confirmed this on slack here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Meshery #13574
Notes for Reviewers
Added new errors to
meshkit/files/errors.go, that are useful for error logging while processing model artifacts. Currently, file errors defined here are specific todesign import, we need to extend error messages to support better error logging inmodel import.Signed commits