Fix ignored models not showing up in Registry and add option to toggle visibility of ignored models #673
Conversation
Signed-off-by: Riya Garg <riyag1452003@gmail.com>
Signed-off-by: Riya Garg <riyag1452003@gmail.com>
There was a problem hiding this comment.
Clarification: Ignored models won’t be hidden in the Registry page.
We want to be able to see both Ignored and Enabled models. Users should be able to mark a model as either Ignored or Enabled. Clients (other pages or other programs) can choose to display or not display / use or not use a model based on whether it is enabled or ignored. But, the Registry page should always show all models. Make sense? (edited)
Please verify whether Meshery Server processes (or does not process) Designs that have components of models set to Ignored.
Remind me: I recommended that you partner with a frontend engineer to see the changes through for complete functionality, is that right? If this functionality (this PR) is ready for review, was there no frontend change needed? Or is the full functionality being separately tracked? I don’t see another linked issue #…
|
Is there a screenshot or video recording of the revised behavior? |
|
Did you clarify the difference between PublishToRegistry and Status? No changes are needed in schema, correct? |
|
I have attached a screen recording showing how after this change, we'll be able to see both ignored and enabled models on Registry Page For the UI toggle feature, I have opened an issue which is linked in description of this PR as well -> issue#13662. This PR is not dependent on UI toggle feature for show/hide ignored models, and hence this PR can be merged so that user can see both enabled and ignored models and toggle between them.
Yes designs that have components of models set to ignored are shown, they aren't hidden. |
I haven't made any schema changes in this PR but I see that PublishToRegistry and status are related. When creating model definition, if publishToRegitry is true, then status is set to enabled, else it is set to ignored |
|
Makes sense. By default, the get should return all records and only filter by status if a specific value is provided. This looks good. Even uncategorized models will not be registered. |
| if mf.Status != "" { | ||
| status = mf.Status | ||
| finder = finder.Where("model_dbs.status = ?", mf.Status) |
There was a problem hiding this comment.
If there is no status filter set, then status can be excluded from the where clause entirely, yeah?
There was a problem hiding this comment.
yes, if status is an empty string (i.e not set), we skip filtering using it.
Description
This PR fixes Meshery issue #13317
Notes for Reviewers
enabled(TODO: a toggle feature on UI, see issue #13662), then ignored models would be hiddenBefore -
Ignored models were not showing up on registry page
After -
Screen.Recording.2025-02-19.at.1.43.05.PM.mov
Signed commits