-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for getMeshSyncStatus #647
Conversation
Signed-off-by: SAGNIK PAL <palsagnik2102@gmail.com>
Signed-off-by: Sagnik Pal <112897062+palSagnik@users.noreply.github.com>
The frontend logic for MeshSync Ad Hoc Connectivity Test was checking for
Will fix in next PR as it needs more trouble shooting |
Is it the frontend that needs to change? Verify against the Meshery Docs page on troubleshooting these connections, please, @palSagnik. |
According to the troubleshooting specs document, the front-end is using the correct terms, there needs to be a change in the backend to fix the ad-hoc connectivity test. |
That may well be true. Thank you for working on this. I need more compelling justification for us to proceed here, however. Research their meanings and differences. This PR eradicates "DEPLOYED" from ever being used? See the Troubleshooting Toolkit google doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More research needed.
After today's call I have understood what you mean, Lee. I will do the required research. |
Description
This PR fixes Meshery Operator Controller checks failing
Notes for Reviewers
Signed commits