Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pull and push from oci registry #483

Merged
merged 16 commits into from
Mar 27, 2024
Merged

feat: pull and push from oci registry #483

merged 16 commits into from
Mar 27, 2024

Conversation

RipulHandoo
Copy link
Contributor

Description

This PR fixes #

  1. Adds feature to pull image's from public OCI registries.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@RipulHandoo
feat: pull from public oci regitry
1ec0fa4 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@welcome Welcome
Copy link

welcome bot commented Mar 18, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@RipulHandoo RipulHandoo requested a review from MUzairS15 March 18, 2024 16:26
leecalcote
leecalcote reviewed Mar 18, 2024
View reviewed changes
leecalcote
leecalcote reviewed Mar 18, 2024
View reviewed changes
leecalcote
leecalcote reviewed Mar 18, 2024
View reviewed changes
models/oci/oci.go Outdated

_ , err = oras.Copy(ctx, repo, imageTag, fs, imageTag, oras.DefaultCopyOptions)
if err != nil {
return ErrGettingImage(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested remediation and probable cause for this error code are pretty terribly written.

meshkit/models/oci/error.go

Line 44 in 75d94b9

func ErrGettingImage(err error) error {

@RipulHandoo
feat: push image to OCI Registry
d91d0aa 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
MUzairS15
MUzairS15 reviewed Mar 19, 2024
View reviewed changes
@RipulHandoo
review fix
78a3568 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo requested a review from MUzairS15 March 20, 2024 06:02
@RipulHandoo
review updates
9c54703 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
MUzairS15
MUzairS15 reviewed Mar 21, 2024
View reviewed changes
@RipulHandoo
adding appropiate err messages
786029e 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo force-pushed the RipulHandoo/pushAndPull branch from 7b6b3f3 to 786029e Compare March 21, 2024 10:36
MUzairS15
MUzairS15 approved these changes Mar 22, 2024
View reviewed changes
Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the description of the errors, the rest LGTM.

@RipulHandoo
fix error code using errorutils
c3d7eaa 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
proper error message
78259d6 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo force-pushed the RipulHandoo/pushAndPull branch from 8b38d71 to 78259d6 Compare March 23, 2024 18:28
@leecalcote
Copy link
Member

Lint checks failing, @RipulHandoo. Please fix.

@RipulHandoo
lint check
dd397e7 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo force-pushed the RipulHandoo/pushAndPull branch from 463b931 to dd397e7 Compare March 24, 2024 05:06
@RipulHandoo
Merge branch 'master' into RipulHandoo/pushAndPull
e3b213f 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
Update go.mod
4feb778 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
Copy link
Contributor Author

Lint checks are failing, @RipulHandoo. Please fix.

I believe there might be an issue with the lint check. I addressed the previous error related to the err variable shadowing, but it's still failing. This seems to be the case for other PRs in the repository as well.

@leecalcote
Copy link
Member

leecalcote commented Mar 27, 2024 •
edited
Loading

@RipulHandoo, you're saying the the lint check test is invalid? That the tool doesn't work?

Or that it's configuration is out of date - - which might be the case.

@leecalcote
Update ci.yml
6177b24 
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote
Copy link
Member

@RipulHandoo this might help - #486

@leecalcote
Merge pull request #486 from meshery/leecalcote/chore/upgrade-golang-…
de97d74 
…lint

[Chore] Workflow action update for golangci-lint to 4.0
@leecalcote
Update ci.yml
049932b 
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Mohd Uzair added 3 commits March 27, 2024 13:46
Merge branch 'master' into RipulHandoo/pushAndPull
418cbce
run go mod tidy
3172ad6 
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
run gofmt
9e15b2f 
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
@MUzairS15
Copy link

@RipulHandoo Be sure to run gofmt, I have pushed the commit, but make sure to do it yourself.

@MUzairS15 MUzairS15 merged commit e96d72e into master Mar 27, 2024
4 checks passed
@MUzairS15 MUzairS15 deleted the RipulHandoo/pushAndPull branch March 27, 2024 08:37
@welcome Welcome
Copy link

welcome bot commented Mar 27, 2024

Thanks for your contribution to Meshery! 🎉

Shows a black logo in light color mode and a white one in dark color mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@MUzairS15 MUzairS15 MUzairS15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RipulHandoo @leecalcote @MUzairS15