Fix design file YAML indentation #13558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Souvik Kar Mahapatra <souvikat001@gmail.com>
|
|
Signed-off-by: Souvik Kar Mahapatra <souvikat001@gmail.com>
1 task
|
@leecalcote implemented changes in MeshKit to enforce YAML indentation and preserve field ordering. |
fitzergerald
approved these changes
Feb 12, 2025
fitzergerald
requested changes
Feb 12, 2025
…aml-indentation-design-file
Signed-off-by: Souvik Kar Mahapatra <souvikat001@gmail.com>
END-TO-END TESTS
📦 Test Result Summary
⌛ Duration: 7 minutes and 53 seconds Overall Result: 👎 Some tests failed. [Show/Hide] Test Result Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This specific part of the code is not using the Yaml converter from encoder in meshkit. Tried incorporating the meshkit encoder however the
ToYamlfirst unmarshalls tomap[string]interface{}and since maps in Go are by definition unordered we are loosing out on the fields arrangement.Ideally we would want to work ensuring that the order of JSON and YAML is maintained right in the encoder and I'm working on it.
Edit:
New changes are incorporated. The MeshKit PR (meshery/meshkit#675) must be merged first, then this one.
Signed commits