-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL injection in /api/system/meshsync/resources #10207
Conversation
Signed-off-by: Xin Huang <xin1.huang@intel.com>
3403dbb
to
d3cd06c
Compare
"Golang Unit and Integration Tests" job failed because of unchanged files, it's not related to my PR, I can raise another PR to fix them. "MeshKit Error Codes Utility Runner" job's error message is |
Thanks for volunteering on
Do you have one already? |
@MUzairS15 Not yet, but I can create one today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in this PR looks great.
Notes for Reviewers
This PR fixes #
As mentioned in GitHub Security Lab (GHSL) Vulnerability Report, this PR is to fix a SQL injection in /api/system/meshsync/resources.
Similar vulnerabilities has been fixed in #9372 using
SanitizeOrderInput
function, which you can uses as a reference.Signed commits