Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert StateDB to TS #6296

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

chore: Convert StateDB to TS #6296

wants to merge 13 commits into from

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Feb 17, 2025

📑 Summary

Convert stateDB and datafetcher into TS.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 5abda14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 5abda14
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67b70babaf791e0008c4f6bd
😎 Deploy Preview https://deploy-preview-6296--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 17, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6296
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6296
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6296
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6296

commit: 5abda14

Copy link

argos-ci bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Feb 20, 2025, 11:24 AM

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 744 lines in your changes missing coverage. Please review.

Project coverage is 4.46%. Comparing base (ad2f172) to head (5abda14).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/state/stateDb.ts 0.00% 693 Missing ⚠️
packages/mermaid/src/diagrams/state/dataFetcher.ts 0.00% 47 Missing ⚠️
packages/mermaid/src/diagrams/state/stateCommon.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6296   +/-   ##
=======================================
  Coverage     4.46%   4.46%           
=======================================
  Files          384     384           
  Lines        54264   54259    -5     
  Branches       623     597   -26     
=======================================
  Hits          2425    2425           
+ Misses       51839   51834    -5     
Flag Coverage Δ
unit 4.46% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/state/shapes.js 0.00% <ø> (ø)
packages/mermaid/src/diagrams/state/stateCommon.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/state/dataFetcher.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/state/stateDb.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

* develop:
  chore: Remove deprecated rule
  chore(deps): update eslint
  chore: Add tslib
  chore(deps): update eslint
  chore: Minor refactor
  chore: Update actions/cache
  chore: Update actions/cache
  added changeset
  added test cases to check state diagram direction
  fix: CodeQL double escape warning
  refatored code
  chore(deps): update eslint
  Fix: state diagram default direction update
  [autofix.ci] apply automated fixes
  fix(deps): update all patch dependencies
@sidharthv96 sidharthv96 marked this pull request as ready for review February 19, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant