refactor(dashboard): rm try catch from formatAdditionalMetric

merico-dev · Dec 19, 2023 · f3508df · f3508df
1 parent 7bacb63
commit f3508df
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 50 deletions.
diff --git a/.../src/components/plugins/viz-components/boxplot-chart/option/tooltip/additional-metrics.ts b/.../src/components/plugins/viz-components/boxplot-chart/option/tooltip/additional-metrics.ts
@@ -3,16 +3,12 @@ import { formatNumber, parseDataKey } from '~/utils';
 import { IBoxplotChartConf } from '../../type';
 
 const formatAdditionalMetric = (v: number) => {
-  try {
-    return formatNumber(v, {
-      output: 'number',
-      trimMantissa: true,
-      mantissa: 2,
-      absolute: false,
-    });
-  } catch (error) {
-    return v;
-  }
+  return formatNumber(v, {
+    output: 'number',
+    trimMantissa: true,
+    mantissa: 2,
+    absolute: false,
+  });
 };
 
 export function getAdditionalMetrics(config: IBoxplotChartConf, dataItem: AnyObject) {

diff --git a/dashboard/src/components/plugins/viz-components/calendar-heatmap/option/tooltip.ts b/dashboard/src/components/plugins/viz-components/calendar-heatmap/option/tooltip.ts
@@ -7,16 +7,12 @@ import { ICalendarHeatmapConf } from '../type';
 import { ValueFormattersType } from './formatters';
 
 const formatAdditionalMetric = (v: number) => {
-  try {
-    return formatNumber(v, {
-      output: 'number',
-      trimMantissa: true,
-      mantissa: 2,
-      absolute: false,
-    });
-  } catch (error) {
-    return v;
-  }
+  return formatNumber(v, {
+    output: 'number',
+    trimMantissa: true,
+    mantissa: 2,
+    absolute: false,
+  });
 };
 
 interface IGetRows {

diff --git a/dashboard/src/components/plugins/viz-components/heatmap/option/tooltip.ts b/dashboard/src/components/plugins/viz-components/heatmap/option/tooltip.ts
@@ -8,16 +8,12 @@ import { IHeatmapConf } from '../type';
 import { LabelFormattersType, ValueFormattersType } from './formatters';
 
 const formatAdditionalMetric = (v: number) => {
-  try {
-    return formatNumber(v, {
-      output: 'number',
-      trimMantissa: true,
-      mantissa: 2,
-      absolute: false,
-    });
-  } catch (error) {
-    return v;
-  }
+  return formatNumber(v, {
+    output: 'number',
+    trimMantissa: true,
+    mantissa: 2,
+    absolute: false,
+  });
 };
 
 interface IGetRows {

diff --git a/dashboard/src/components/plugins/viz-components/merico-heatmap/render/option/tooltip.ts b/dashboard/src/components/plugins/viz-components/merico-heatmap/render/option/tooltip.ts
@@ -8,16 +8,12 @@ import { TMericoHeatmapConf } from '../../type';
 import { LabelFormattersType, ValueFormattersType } from './formatters';
 
 const formatAdditionalMetric = (v: number) => {
-  try {
-    return formatNumber(v, {
-      output: 'number',
-      trimMantissa: true,
-      mantissa: 2,
-      absolute: false,
-    });
-  } catch (error) {
-    return v;
-  }
+  return formatNumber(v, {
+    output: 'number',
+    trimMantissa: true,
+    mantissa: 2,
+    absolute: false,
+  });
 };
 
 interface IGetRows {

diff --git a/dashboard/src/components/plugins/viz-components/scatter-chart/option/tooltip.ts b/dashboard/src/components/plugins/viz-components/scatter-chart/option/tooltip.ts
@@ -31,16 +31,12 @@ function getXAxisLabel(params: AnyObject[], conf: IScatterChartConf) {
 }
 
 const formatAdditionalMetric = (v: number) => {
-  try {
-    return formatNumber(v, {
-      output: 'number',
-      trimMantissa: true,
-      mantissa: 2,
-      absolute: false,
-    });
-  } catch (error) {
-    return v;
-  }
+  return formatNumber(v, {
+    output: 'number',
+    trimMantissa: true,
+    mantissa: 2,
+    absolute: false,
+  });
 };
 
 export function getTooltip(conf: IScatterChartConf, labelFormatters: Record<string, (p: $TSFixMe) => string>) {