Polish apache#2897 : rename DubboConfigConfigurationSelector to Dubbo…

…ConfigConfigurationRegistrar
mercyblitz · Dec 7, 2018 · b328a7d · b328a7d
1 parent b41ee81
commit b328a7d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/...ion/DubboConfigConfigurationSelector.java → ...on/DubboConfigConfigurationRegistrar.java b/...ion/DubboConfigConfigurationSelector.java → ...on/DubboConfigConfigurationRegistrar.java
@@ -21,7 +21,6 @@
 import org.springframework.beans.factory.support.BeanDefinitionRegistry;
 import org.springframework.context.EnvironmentAware;
 import org.springframework.context.annotation.ImportBeanDefinitionRegistrar;
-import org.springframework.context.annotation.ImportSelector;
 import org.springframework.core.Ordered;
 import org.springframework.core.annotation.AnnotationAttributes;
 import org.springframework.core.env.Environment;
@@ -30,14 +29,14 @@
 import static com.alibaba.spring.util.AnnotatedBeanDefinitionRegistryUtils.registerBeans;
 
 /**
- * Dubbo {@link AbstractConfig Config} {@link ImportSelector} implementation, which order can be configured
+ * Dubbo {@link AbstractConfig Config} {@link ImportBeanDefinitionRegistrar register}, which order can be configured
  *
  * @see EnableDubboConfig
  * @see DubboConfigConfiguration
  * @see Ordered
  * @since 2.5.8
  */
-public class DubboConfigConfigurationSelector implements ImportBeanDefinitionRegistrar, EnvironmentAware, Ordered {
+public class DubboConfigConfigurationRegistrar implements ImportBeanDefinitionRegistrar, EnvironmentAware, Ordered {
 
     /**
      * The property name of {@link EnableDubboConfig}'s {@link Ordered order}

diff --git a/...g/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/EnableDubboConfig.java b/...g/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/EnableDubboConfig.java
@@ -59,14 +59,14 @@
  *
  * @see EnableDubboConfigBinding
  * @see DubboConfigConfiguration
- * @see DubboConfigConfigurationSelector
+ * @see DubboConfigConfigurationRegistrar
  * @since 2.5.8
  */
 @Target({ElementType.TYPE})
 @Retention(RetentionPolicy.RUNTIME)
 @Inherited
 @Documented
-@Import(DubboConfigConfigurationSelector.class)
+@Import(DubboConfigConfigurationRegistrar.class)
 public @interface EnableDubboConfig {
 
     /**

diff --git a/...c/test/java/com/alibaba/dubbo/config/spring/context/annotation/EnableDubboConfigTest.java b/...c/test/java/com/alibaba/dubbo/config/spring/context/annotation/EnableDubboConfigTest.java
@@ -35,7 +35,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
-import static com.alibaba.dubbo.config.spring.context.annotation.DubboConfigConfigurationSelector.DUBBO_CONFIG_ORDER_PROPERTY_NAME;
+import static com.alibaba.dubbo.config.spring.context.annotation.DubboConfigConfigurationRegistrar.DUBBO_CONFIG_ORDER_PROPERTY_NAME;
 
 /**
  * {@link EnableDubboConfig} Test
@@ -53,7 +53,7 @@ public void testOrder() {
 
         environment.getPropertySources().addFirst(propertySource);
 
-        DubboConfigConfigurationSelector selector = new DubboConfigConfigurationSelector();
+        DubboConfigConfigurationRegistrar selector = new DubboConfigConfigurationRegistrar();
 
         selector.setEnvironment(environment);