Fix argument handling in sigrok file generation #3161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 96226b5 (October 2023), when building the arguments for
zip
for creating a sigrok file, the arg count is incremented multiple times for each analog file, leaving extraNULL
s, causing only the first analog file to be included. Any other analog files are not included in the zip file and are not cleaned up afterwards.This PR removes the extra increment, allowing all files to be included in the sigrok file and cleaned up afterwards.
Before:
After: