Decodes the Nice FloR code and serial values #3159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand your position. Thanks for your work. If you think I must delete my fork, tell me and I'll do it
…________________________________
From: Christian W. Zuckschwerdt ***@***.***>
Sent: Sunday, January 26, 2025 12:25:49 PM
To: merbanan/rtl_433 ***@***.***>
Cc: chirrindul ***@***.***>; Author ***@***.***>
Subject: Re: [merbanan/rtl_433] Decodes the Nice FloR code and serial values (PR #3159)
S.a. #2238<#2238> and #2344<#2344>
This looks good, but we are unlikely to add cryptographic routines to rtl_433. Using a script or binary to post-process outputs might be better suited.
—
Reply to this email directly, view it on GitHub<#3159 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEJLJHCYC37WJBG4ZNR42BT2MTA33AVCNFSM6AAAAABV2L72CWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGMZTGNRXGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
No harm in keeping this. And you can have your own fork and distribute it if you like. |
|
Well calling this thing crypto was generous. I think we can accept the code (with some cleanup). The ikea sparsnäs code is similar. There we unscramble the data out of the box. |
|
Hmm, but what is this large table needed for? The following code has no large table like that: |
|
I suppose using tables is the brute force way when people didn't know the formula behind.
It's cool to know the code that makes the tables. Thanks.
As you see I'm a bad programmer.
Enviado desde Outlook para Android<https://aka.ms/AAb9ysg>
…________________________________
From: Benjamin Larsson ***@***.***>
Sent: Sunday, January 26, 2025 3:56:28 PM
To: merbanan/rtl_433 ***@***.***>
Cc: chirrindul ***@***.***>; Author ***@***.***>
Subject: Re: [merbanan/rtl_433] Decodes the Nice FloR code and serial values (PR #3159)
Hmm, but what is this large table needed for?
The following code has no large table like that:
https://github.com/DarkFlippers/unleashed-firmware/blob/dev/lib/subghz/protocols/nice_flor_s.c#L433
—
Reply to this email directly, view it on GitHub<#3159 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEJLJHF3PTM7ELUGWXJFYZ32MTZRZAVCNFSM6AAAAABV2L72CWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGQ2TONRYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Oh, I didn't see the code. After doing it I remember it, it's part of FlipperZero.
There were also tables that are loaded from the filesystem and probably are encrypted.
Enviado desde Outlook para Android<https://aka.ms/AAb9ysg>
…________________________________
From: Mr 101 ***@***.***>
Sent: Sunday, January 26, 2025 6:49:46 PM
To: merbanan/rtl_433 ***@***.***>; merbanan/rtl_433 ***@***.***>
Cc: Author ***@***.***>
Subject: Re: [merbanan/rtl_433] Decodes the Nice FloR code and serial values (PR #3159)
I suppose using tables is the brute force way when people didn't know the formula behind.
It's cool to know the code that makes the tables. Thanks.
As you see I'm a bad programmer.
Enviado desde Outlook para Android<https://aka.ms/AAb9ysg>
________________________________
From: Benjamin Larsson ***@***.***>
Sent: Sunday, January 26, 2025 3:56:28 PM
To: merbanan/rtl_433 ***@***.***>
Cc: chirrindul ***@***.***>; Author ***@***.***>
Subject: Re: [merbanan/rtl_433] Decodes the Nice FloR code and serial values (PR #3159)
Hmm, but what is this large table needed for?
The following code has no large table like that:
https://github.com/DarkFlippers/unleashed-firmware/blob/dev/lib/subghz/protocols/nice_flor_s.c#L433
—
Reply to this email directly, view it on GitHub<#3159 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEJLJHF3PTM7ELUGWXJFYZ32MTZRZAVCNFSM6AAAAABV2L72CWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGQ2TONRYGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is interesting to see the unencrypted values for "code" and "serial". In this way you can see how you have cloned a new remote control and you can see how the "code" is increased on every new use of the remote control.
Credits to
and
This is my first pull request, so forgive errors.