mongoose.c: Fix SO_NOSIGPIPE change #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On NetBSD 10, this fails to build, with both sock and nopipe
undefined, and code reading agrees with the compiler.
- Define nopipe, used in the ioctl, guarded by the same ifdef, in 2 places.
- Add ifdef guard in the 1 existing place
- Use nc->sock instead of bare sock
|
I don't see that the build failure is related to building on NetBSD. From code reading, this must fail to build on all platforms that support |
|
rtl_433 builds ok on Raspberry Pi OS 12 and actual Debian 12, but both appear not to define SO_NOSIGPIPE. This PR builds ok on Debian 12. |
|
Thanks! I made quite some copy+paste errors there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On NetBSD 10, this fails to build, with both sock and nopipe undefined, and code reading agrees with the compiler.