Update rtl_433_mqtt_hass.py to add battery_mV #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to battery_ok, many devices also surface the measured battery voltage.
|
I more or less think it's a bug that we have battery_mV, instead of battery_V, SI base units and all that, but given that we do we might as well send a discovery message. |
|
I agree that it should be "battery_V" but that was a bigger patch than I wanted to write, especially since it would touch nearly every file in src/devices/* |
zuckschwerdt
pushed a commit
that referenced
this pull request
Nov 28, 2023
In addition to battery_ok, many devices also surface the measured battery voltage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to battery_ok, many devices also surface the measured battery voltage.
This is a decomposed part of #2581