This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Make this repo installable with all python versions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlpAribal
reviewed
Aug 31, 2022
AlpAribal
reviewed
Aug 31, 2022
| @@ -11,9 +11,9 @@ | |||
| def squirrel_drivers() -> List[Type[Driver]]: | |||
| """Custom drivers added by this package.""" | |||
| import squirrel_datasets_core.datasets as ds | |||
| from squirrel_datasets_core.driver.hub import HubDriver | |||
| from squirrel_datasets_core.driver.huggingface import HuggingfaceDriver | |||
| from squirrel_datasets_core.driver.torchvision import TorchvisionDriver | |||
There was a problem hiding this comment.
I expect this line to fail when torchvision is not installed.
AlpAribal
approved these changes
Sep 1, 2022
| @@ -25,7 +25,7 @@ | |||
| "\n", | |||
| " restart_colab = False\n", | |||
| "except:\n", | |||
| " !pip install -q --ignore-requires-python --upgrade squirrel-datasets-core matplotlib # noqa\n", | |||
| " !pip install -q --ignore-requires-python --upgrade \"squirrel-datasets-core[torchvision]\" matplotlib # noqa\n", | |||
There was a problem hiding this comment.
Out of curiosity: Are quotes necessary?
There was a problem hiding this comment.
It works both ways
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # issue
Type of change
Checklist: