Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Remove hydra dependency #39

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Remove hydra dependency #39

merged 4 commits into from
Jun 13, 2022

Conversation

AlpAribal
Copy link
Contributor

Description

Removes hydra dependency as it is not used and refreezes requirements to reflect the change in reqs.txt. squirrel version is bumped with the new freeze.

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@@ -1,11 +1,10 @@
datasets
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies sorted alphabetically, only hydra removed, no other changes

@@ -219,12 +215,37 @@ numba==0.55.1 \
--hash=sha256:6d0042371880fa56ed58be27502b11a08bff0b6335f0ebde82af1a7aef5e1287
numcodecs==0.9.1 \
--hash=sha256:3fdb7b43984d77f7fa7e7fb0776ad552d1bd7c078bc08564b439202235f52cbe
numpy==1.21.5 \
--hash=sha256:eed2afaa97ec33b4411995be12f8bdb95c87984eaa28d76cf628970c8a2d689a
numpy==1.21.0 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is fixed by newer version of squirrel

@AlpAribal AlpAribal requested a review from winfried-ripken June 9, 2022 15:06
Copy link
Contributor

@winfried-ripken winfried-ripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thank you!

@AlpAribal AlpAribal force-pushed the alp-minor-reqs-update branch from 4bdf499 to ddfaf4a Compare June 10, 2022 12:37
@AlpAribal AlpAribal merged commit 7a91cff into main Jun 13, 2022
@AlpAribal AlpAribal deleted the alp-minor-reqs-update branch June 13, 2022 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants