[f5121] Xiaomi Redmi 5 Plus (vince) compatibility fixes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a hardcoded Sony XperiaX specific max_brightness workaround in f5121 backend. This stops the backend from being usable with other devices like vince. To make f5121 backend more generic, add MaxBrightnessOverride configuration option and use it for handling f5121 special needs. Ad example Xiaomi Redmi 5 Plus (vince) configuration file. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Changing values originating from sysfs files that have deliberately been opened in read-only mode leads to journal spamming as write attempts fail. Such value changes are expected when dealing with for example configuration entries dealing with overriding max_brightness values. Keep track in what kind of mode a file was opened. In case of read-only mode, just update internally cache state and skip write attempt. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.