Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move vertical-align to td, th to avoid UA style dependency (#608) #610

Merged
merged 1 commit into from
May 27, 2021

Conversation

asavartsov
Copy link
Contributor

Fixes #608 by moving vertical-align propery to td and th tags as style defined on table has no effect (at least in Google Chrome) because of inheritnce of td and th on tbody and thead which does not inherit vertical-align from table by default.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 220

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.792%

Totals Coverage Status
Change from base Build 219: 0.0%
Covered Lines: 763
Relevant Lines: 826

💛 - Coveralls

@mengxiong10 mengxiong10 merged commit 705c100 into mengxiong10:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Day cell aligment depends on user agent stylesheet [Bug]
3 participants