-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Open time picker if time is clicked or date picker if date is clicked #457
Comments
There is already a prop |
Thanks for the response. I appreciate it. I'm not sure if the Nextcloud team will want to split up the date/time picker into two separate elements though. The UI might start to look cluttered. Would it be possible to do this while keeping everything in one element and just detecting where the user clicked? |
It can also be calculated based on |
Ok, so we could detect the coordinates of the mouse click and see if they are over the time element and then set I'm trying to understand the code. It looks like all clicks on the component are handled here. But, I don't see an I apologize. I'm still trying to understand how Vue works. I would be happy to learn and put together a PR if that would be helpful, but I could use a bit of guidance on how the component works. |
Yes, I'll add the object |
Thanks for doing that! I appreciate it. So, now the high level process to open the time picker if the time is clicked would be:
Is that correct? |
That's awesome! Thank you so much for putting that together. :) I think this issue is pretty much wrapped up at this point. |
What problem does this feature solve?
I'm using Nextcloud Calendar which uses this date picker for setting calendar event dates and times. In general it works great, but I feel the flow for selecting an event time could be faster. Right now in order to select a time we do:
I think we could remove step 2 by listening for where the user clicks. If they click on the time, show the time picker, if they click on the date, show the date picker.
What does the proposed API look like?
Maybe a setting switch "prop" that could enable this functionality? I'm not really a Vue guy, so I'm not sure what the right terminology is.
That's my 0.02. Thanks for sharing this great component. :)
The text was updated successfully, but these errors were encountered: