Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish step on CI/CD pipeline #25

Closed
wants to merge 4 commits into from

Conversation

aleortega
Copy link

These changes should fix the errors we are encountering when trying to publish a library to the NPM registry.
An error example can be found here in this WKC repository.

@aleortega
Copy link
Author

Hey @menduz :)

Could you check this whenever you have time? I'm about to propose the creation of a new WKC component, but to do so, we first need to fix the CI/CD pipelines happening there.

These changes made by Juanma on the forked we did, fixed our pipelines

@menduz
Copy link
Owner

menduz commented Mar 6, 2025

Hi Ale, those changes are already in master. Can you check?

Also, we should not make this pipeline depend on decentraland/oddish-action

I really think it would be best if we all contribute to this repo only, I see no reason on having two forks

The changes were upstreamed in pr #24

The error you are seeing in base-ts-project is because the pipeline is lacking the permissions

    permissions:
      id-token: write

@aleortega
Copy link
Author

Also, we should not make this pipeline depend on decentraland/oddish-action

I really think it would be best if we all contribute to this repo only, I see no reason on having two forks

Oof, my bad, was rushing this and didn't check the changes injected here

Just checked and yes, the changes are already in the default branch, will close this PR. Thank you and sorry!

@aleortega aleortega closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants