Push/pop attributes for SVG element. Add support for x and y attributes.

[mindbrix]

Hi. This fixes the attached SVG.

material_design_icons.svg.zip

[FitzerIRL]

This is nice !

[mindbrix]

On closer inspection, attribute parsing needs to be element specific is some cases, e.g. x and y for concatenates a translation matrix, but sets the lower point for the rect element

Also, transforms attributes need priority for (and possible others), but they are currently parsed in the order they are found. The attached file illustrates this issue.

Accordion.svg.zip

[SergeySlice]

Such picture?

:)

[mindbrix]

Yes. Fixed, but it needs more work.

[mindbrix]

f8d80bc fixes rects while still supporting x and y attributes for the svg element

[SergeySlice]

OK. One moment else. Should we perform parsing "transform" after parsing "x" and "y" in nsvg__parseAttr?
The order is significant.

[SergeySlice]

O, I see you already said this
"Also, transforms attributes need priority for (and possible others), but they are currently parsed in the order they are found."
Somehow reorder attributes?

[SergeySlice]

Or just don't multiply matrices until parseAttr will finish.

[mindbrix]

@SergeySlice my analysis was incorrect. The problem was that for rects the x and y attributes were being consumed twice and concatenating an unnecessary translation. This is now fixed.

[SergeySlice]

All is good now.