Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ci check for building w/ component #3

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add a ci check for building w/ component #3

merged 1 commit into from
Oct 23, 2024

Conversation

noahp
Copy link
Collaborator

@noahp noahp commented Oct 23, 2024 •
edited
Loading

Changes to support building in 3 configurations:

  1. (default) Memfault SDK is git submodule
  2. this app is located inside the Memfault SDK, at examples/esp32/app/memfault
  3. using the Memfault ESP component (requires running idf.py add-dependency "memfault/memfault-firmware-sdk" to install the dep)

@noahp noahp force-pushed the noahp/ci-check-component branch from 2f7b4f6 to e6db454 Compare October 23, 2024 13:46
@noahp noahp requested a review from gminn October 23, 2024 13:47
@noahp noahp force-pushed the noahp/ci-check-component branch 2 times, most recently from 7955094 to cd52a4c Compare October 23, 2024 13:51
gminn
gminn approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@gminn gminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot better than a separate branch

@noahp noahp force-pushed the noahp/ci-check-component branch from cd52a4c to e90d002 Compare October 23, 2024 14:20
@noahp noahp merged commit 0aafaa5 into main Oct 23, 2024
2 checks passed
@noahp noahp deleted the noahp/ci-check-component branch October 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gminn gminn gminn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahp @gminn