Create Decoders #1
Conversation
| [] | ||
| end | ||
|
|
||
| buffers = Enum.map(decoded_frames, &%Buffer{payload: &1, pts: pts}) |
There was a problem hiding this comment.
Do we have a guarantee that Native.decode_frame won't return some "buffered" frames, that should have different PTS? (I am slightly worried of that as decode_frame returns a list of frames)
There was a problem hiding this comment.
I believe we do, since there is no flushing mechanism
There was a problem hiding this comment.
Ok, so could we match on [decoded_frame] = decoded_frames? This way we will have a clear error message if for some reason decoder returns more than one frame, that could potentially mess up timestamps
| state.framerate || raise("Framerate not provided") | ||
| } | ||
|
|
||
| %^codec_module{width: width, height: height, framerate: framerate} -> |
There was a problem hiding this comment.
do we really need that codec_module here? It's only stored in the state to be used here.
You could match on %{width: width, height: height, framerate: framerate} and the stream format definition will make sure that no other module than VP8 or VP9 can be applied here.
There was a problem hiding this comment.
I did this to ensure the stream format is actually matching the codec, but i guess accepted_format is enough
The decoding nifs are mostly based on this example