fix: slashes in destinationtype raise cypher error #2374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
llm generated destinationtype with slashes (eg Software/Model)
This raises an error because neo4j cypher does not allow slashes in entity names.
Extended the existing sanitizing method (replace spaces) to include replacing / with : and renamed it to _remove_invalid_chars_from_entities to reflect the more general functionality.
using : in cyphr allows us to define more than one label (which is pretty much what the llm was trying to do)
Fixes # (issue)
I did not report the issue, I just went and fixed it.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: