Fixed passing wrong offset
value for comparing few DateComparisonType
#124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing yesterday's date with
.compare(.isTomorrow)
, the function is returningtrue
which is wrong.Example:
The same happens for comparing the following
DateComparisonType
Changes:
Bug:
During the comparison of the date, the
offset
for.isSameDay
was passed based on the difference betweenDate()
andself
, which is a bug.Fix:
Fixed it by passing the
offset
value calculated based on theDateComparisonType
.