fix(templates): Include package license metadata conditionally in tem…

…plates (#2862) * Include package license metadata conditionally * Also apply for target and mapper templates * Optimistically reference `LICENSE` file * Add a replay file for the no license case --------- Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
meltano · Jan 31, 2025 · 3c80245 · 3c80245
1 parent a609f4b
commit 3c80245
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 3 deletions.
diff --git a/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/pyproject.toml b/cookiecutter/mapper-template/{{cookiecutter.mapper_id}}/pyproject.toml
@@ -15,15 +15,19 @@ keywords = [
 ]
 classifiers = [
     "Intended Audience :: Developers",
+{%- if cookiecutter.license == "Apache-2.0" %}
     "License :: OSI Approved :: Apache Software License",
+{%- endif %}
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: 3.13",
 ]
-license = "Apache-2.0"
+{%- if cookiecutter.license != "None" %}
+license = "{{cookiecutter.license}}"
+{%- endif %}
 license-files = [ "LICENSE" ]
 requires-python = ">=3.9"
 dependencies = [

diff --git a/cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml b/cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
@@ -18,15 +18,19 @@ keywords = [
 ]
 classifiers = [
     "Intended Audience :: Developers",
+{%- if cookiecutter.license == "Apache-2.0" %}
     "License :: OSI Approved :: Apache Software License",
+{%- endif %}
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: 3.13",
 ]
-license = "Apache-2.0"
+{%- if cookiecutter.license != "None" %}
+license = "{{cookiecutter.license}}"
+{%- endif %}
 license-files = [ "LICENSE" ]
 requires-python = ">=3.9"
 dependencies = [

diff --git a/cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml b/cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml
@@ -14,15 +14,19 @@ keywords = [
 ]
 classifiers = [
     "Intended Audience :: Developers",
+{%- if cookiecutter.license == "Apache-2.0" %}
     "License :: OSI Approved :: Apache Software License",
+{%- endif %}
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: 3.13",
 ]
-license = "Apache-2.0"
+{%- if cookiecutter.license != "None" %}
+license = "{{cookiecutter.license}}"
+{%- endif %}
 license-files = [ "LICENSE" ]
 requires-python = ">=3.9"
 dependencies = [

diff --git a/e2e-tests/cookiecutters/tap-no-license.json b/e2e-tests/cookiecutters/tap-no-license.json
@@ -0,0 +1,18 @@
+{
+    "cookiecutter": {
+      "source_name": "AutomaticTestTap",
+      "admin_name": "Automatic Tester",
+      "admin_email": "auto.tester@example.com",
+      "tap_id": "tap-no-license",
+      "library_name": "tap_no_license",
+      "variant": "None (Skip)",
+      "stream_type": "REST",
+      "auth_method": "Basic Auth",
+      "include_ci_files": "None (Skip)",
+      "faker_extra": false,
+      "license": "None",
+      "ide": "VSCode",
+      "_template": "../tap-template/",
+      "_output_dir": "."
+    }
+}