Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use PyPI OIDC to publish #97

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Apr 18, 2023

TODO: decide if we want to set up an environment for releases.

For now, I've created a published without an environment.


📚 Documentation preview 📚: https://meltano-edk--97.org.readthedocs.build/en/97/

TODO: decide if we want to set up an _environment_ for releases.

For now, I've created a published without an environment.
@WillDaSilva
Copy link
Member

@edgarrmondragon How much work (both now and ongoing) is it to set up & use an environment for releases? Even if we don't need it, if it isn't much work I'd still support us using an environment for releases since that'll make it easier to e.g. require approval for publishing later.

@edgarrmondragon
Copy link
Collaborator Author

@edgarrmondragon How much work (both now and ongoing) is it to set up & use an environment for releases? Even if we don't need it, if it isn't much work I'd still support us using an environment for releases since that'll make it easier to e.g. require approval for publishing later.

@WillDaSilva It's a really simple process:

  1. Recreate the publisher in PyPI to use the publishing environment
  2. Create the publishing environment in this repo with basic settings, e.g. limit to v* tags
  3. Update this PR to make the job use that environment

It's a bit of click-ops that in total that takes 10 minutes max. Though, I don't have access to all settings in this repo so I can't create the environment (cc @tayloramurphy).

@WillDaSilva
Copy link
Member

Though, I don't have access to all settings in this repo so I can't create the environment

@edgarrmondragon I've made you an org owner, so you should now have the required permissions. After this process is done you or I can drop your access level down to member.

@tayloramurphy
Copy link
Contributor

@WillDaSilva @edgarrmondragon currently Edgar is Admin on SDK repo - do we want the same on the EDK repo?

@edgarrmondragon edgarrmondragon temporarily deployed to publishing April 19, 2023 17:19 — with GitHub Actions Inactive
@edgarrmondragon
Copy link
Collaborator Author

@WillDaSilva @edgarrmondragon currently Edgar is Admin on SDK repo - do we want the same on the EDK repo?

Yeah, that'd be fine by me 🙂.

@edgarrmondragon
Copy link
Collaborator Author

Published successfully: https://pypi.org/project/meltano-edk/0.3.1a1/

@edgarrmondragon edgarrmondragon marked this pull request as ready for review April 19, 2023 17:24
@edgarrmondragon
Copy link
Collaborator Author

Published successfully: https://pypi.org/project/meltano-edk/0.3.1a1/

@edgarrmondragon edgarrmondragon merged commit 88c803d into main Apr 19, 2023
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon-patch-1 branch April 19, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants