fix: Propagate SIGINT
to subprocess
#75
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My knowledge of
asyncio
is quite limited but this seems to fix the issue for me. Please let me know if this can be optimised or there is more of a best-practice approach.Could of unresolved minor issues:
got 3 SIGTERM/SIGINTs, forcing shutdown
message is about - this doesn't happen when I Ctrl+C adocker compose up
process directlydocker compose up
process is130
, but here it is1
(could be down to the above error)Checklist
SIGINT
signal toasyncio
subprocessResolves #74
📚 Documentation preview 📚: https://meltano-edk--75.org.readthedocs.build/en/75/