Skip to content

Commit

Permalink
feat: remove Js.null_undefined (#930)
Browse files Browse the repository at this point in the history
* feat: remove `Js.null_undefined`

use Js.nullable instead

* chore: add changelog entry
  • Loading branch information
anmonteiro authored Nov 25, 2023
1 parent c3bba63 commit 166cdba
Show file tree
Hide file tree
Showing 8 changed files with 3,317 additions and 3,317 deletions.
2 changes: 2 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ Unreleased
[#928](https://github.com/melange-re/melange/pull/928))
- Fix a typo in `Node.node_module` (pa{r,}rent)
[#929](https://github.com/melange-re/melange/pull/929)
- BREAKING(runtime): Remove `Js.null_undefined` in favor of `Js.nullable`
([#930](https://github.com/melange-re/melange/pull/930))

2.1.0 2023-10-22
---------------
Expand Down
2 changes: 0 additions & 2 deletions jscomp/runtime/js.ml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ type +'a nullable = 'a Js_nullable.t
(** A value of this type can be [undefined], [null] or ['a].
This type is the same as type [t] n {!Nullable} *)

type +'a null_undefined = 'a nullable

module Exn = Js_exn
(** Provide utilities for dealing with Js exceptions *)

Expand Down
Loading

0 comments on commit 166cdba

Please sign in to comment.