Split spec/integration_spec.rb

spec/instance_methods_spec.rb

@@ -45,5 +45,15 @@
         a_hash_including('taskUid')
       )
     end
+
+    it 'throws error on non-persisted instances' do
+      expect { Color.new(name: 'purple').index!(true) }.to raise_error(ArgumentError)
+    end
+  end
+
+  describe '#ms_remove_from_index!' do
+    it 'throws error on non-persisted instances' do
+      expect { Color.new(name: 'purple').remove_from_index!(true) }.to raise_error(ArgumentError)
+    end
   end
 end

spec/integration/active_record/record_is_updated_spec.rb

@@ -1,6 +1,17 @@
 require 'support/models/book'
+require 'support/models/color'
 
 describe 'When record is updated' do
+  it 'updates the changed attributes on the index' do
+    purple = Color.create!(name: 'purple', short_name: 'p')
+    expect(Color.search('purple')).to be_one
+    expect(Color.search('pink')).to be_empty
+
+    purple.update name: 'pink'
+    expect(Color.search('purple')).to be_empty
+    expect(Color.search('pink')).to be_one
+  end
+
   it 'automatically removes document from conditional indexes' do
     TestUtil.reset_books!
 

spec/integration_spec.rb

@@ -112,64 +112,6 @@
   end
 end
 
-describe 'Colors' do
-  before do
-    Color.clear_index!(true)
-    Color.delete_all
-  end
-
-  it 'auto indexes' do
-    blue = Color.create!(name: 'blue', short_name: 'b', hex: 0xFF0000)
-    results = Color.search('blue')
-    expect(results.size).to eq(1)
-    expect(results).to include(blue)
-  end
-
-
-  it 'is able to temporarily disable auto-indexing' do
-    Color.without_auto_index do
-      Color.create!(name: 'blue', short_name: 'b', hex: 0xFF0000)
-    end
-    expect(Color.search('blue').size).to eq(0)
-    Color.reindex!(MeiliSearch::Rails::IndexSettings::DEFAULT_BATCH_SIZE, true)
-    expect(Color.search('blue').size).to eq(1)
-  end
-
-  it 'updates the index if the attribute changed' do
-    purple = Color.create!(name: 'purple', short_name: 'p')
-    expect(Color.search('purple').size).to eq(1)
-    expect(Color.search('pink').size).to eq(0)
-    purple.name = 'pink'
-    purple.save
-    expect(Color.search('purple').size).to eq(0)
-    expect(Color.search('pink').size).to eq(1)
-  end
-
-  it 'uses the specified scope' do
-    Color.create!(name: 'red', short_name: 'r3', hex: 3)
-    Color.create!(name: 'red', short_name: 'r1', hex: 1)
-    Color.create!(name: 'red', short_name: 'r2', hex: 2)
-    Color.create!(name: 'purple', short_name: 'p')
-    Color.clear_index!(true)
-    Color.where(name: 'red').reindex!(MeiliSearch::Rails::IndexSettings::DEFAULT_BATCH_SIZE, true)
-    expect(Color.search('').size).to eq(3)
-    Color.clear_index!(true)
-    Color.where(id: Color.first.id).reindex!(MeiliSearch::Rails::IndexSettings::DEFAULT_BATCH_SIZE, true)
-    expect(Color.search('').size).to eq(1)
-  end
-
-  it 'indexes an array of documents' do
-    json = Color.raw_search('')
-    Color.index_documents Color.limit(1), true # reindex last color, `limit` is incompatible with the reindex! method
-    expect(json['hits'].count).to eq(Color.raw_search('')['hits'].count)
-  end
-
-  it 'does not index non-saved document' do
-    expect { Color.new(name: 'purple').index!(true) }.to raise_error(ArgumentError)
-    expect { Color.new(name: 'purple').remove_from_index!(true) }.to raise_error(ArgumentError)
-  end
-end
-
 describe 'An imaginary store' do
   before(:all) do
     Product.clear_index!(true)

spec/model_methods_spec.rb

@@ -0,0 +1,64 @@
+require 'support/models/color'
+require 'support/models/book'
+
+describe 'Model methods' do
+  describe '.reindex!' do
+    it 'uses the specified scope' do
+      TestUtil.reset_colors!
+
+      Color.create!(name: 'red', short_name: 'r3', hex: 3)
+      Color.create!(name: 'red', short_name: 'r1', hex: 1)
+      Color.create!(name: 'purple', short_name: 'p')
+
+      Color.clear_index!(true)
+
+      Color.where(name: 'red').reindex!(3, true)
+      expect(Color.search('').size).to eq(2)
+
+      Color.clear_index!(true)
+      Color.where(id: Color.first.id).reindex!(3, true)
+      expect(Color.search('').size).to eq(1)
+    end
+  end
+
+  describe '.without_auto_index' do
+    it 'disables auto indexing for the model' do
+      TestUtil.reset_colors!
+
+      Color.without_auto_index do
+        Color.create!(name: 'blue', short_name: 'b', hex: 0xFF0000)
+      end
+
+      expect(Color.search('blue')).to be_empty
+
+      Color.reindex!(2, true)
+      expect(Color.search('blue')).to be_one
+    end
+
+    it 'does not disable auto indexing for other models' do
+      TestUtil.reset_books!
+
+      Color.without_auto_index do
+        Book.create!(
+          name: 'Frankenstein', author: 'Mary Shelley',
+          premium: false, released: true
+        )
+      end
+
+      expect(Book.search('Frankenstein')).to be_one
+    end
+  end
+
+  describe '.index_documents' do
+    it 'updates existing documents' do
+      TestUtil.reset_colors!
+
+      _blue = Color.create!(name: 'blue', short_name: 'blu', hex: 0x0000FF)
+      _black = Color.create!(name: 'black', short_name: 'bla', hex: 0x000000)
+
+      json = Color.raw_search('')
+      Color.index_documents Color.limit(1), true # reindex last color, `limit` is incompatible with the reindex! method
+      expect(json['hits'].count).to eq(Color.raw_search('')['hits'].count)
+    end
+  end
+end

spec/options_spec.rb

@@ -22,9 +22,8 @@
   end
 
   describe ':auto_index' do
-    it 'auto indexes by default' do
-      Color.clear_index!(true)
-      Color.delete_all
+    it 'is enabled by default' do
+      TestUtil.reset_colors!
 
       Color.create!(name: 'blue', short_name: 'b', hex: 0xFF0000)
       results = Color.raw_search('blue')

spec/search_spec.rb

@@ -56,8 +56,8 @@
 
 describe '#raw_search' do
   it 'allows for access to meilisearch-ruby search' do
-    Color.clear_index!(true)
-    Color.delete_all
+    TestUtil.reset_colors!
+
     Color.create!(name: 'blue', short_name: 'b', hex: 0xFF0000)
 
     raw_results = Color.raw_search('blue')

spec/support/models/color.rb

@@ -35,3 +35,10 @@ def will_save_change_to_short_name?
     false
   end
 end
+
+module TestUtil
+  def self.reset_colors!
+    Color.clear_index!(true)
+    Color.delete_all
+  end
+end