Add return value to ms_index! #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 10 10
Lines 657 657
=======================================
Hits 585 585
Misses 72 72 ☔ View full report in Codecov by Sentry. |
brunoocasali
requested changes
Oct 6, 2023
3beffc1 to
857e72f
Compare
|
@brunoocasali sorry for being inactive this month, this and the other PRs should be ready to merge if you agree with the changes. |
50e7c70 to
87dcae7
Compare
|
Hey @ellnix I asked some questions in the last review, could you check them? |
|
bors merge |
|
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #271
What does this PR do?
#ms_index!to pass along the task hash provided by the meilisearch gemPR checklist
Please check if your PR fulfills the following requirements:
I'm new to this project, so I tried to keep the solution as unopinionated as possible. Please feel free to suggest changes to the implementation.