Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vite global patch for browser environments #1829

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 17, 2025

Pull Request

What does this PR do?

  • adjust footer applied by Vite, so that it doesn't cause issues with Node.js, and doesn't apply default export to global variable

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 added the bug Something isn't working label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (489b583) to head (80bc464).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1829   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          17       17           
  Lines        1565     1565           
  Branches      333      333           
=======================================
  Hits         1537     1537           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flevi29 flevi29 requested a review from Strift January 17, 2025 14:23
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Jan 20, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 0b829db into meilisearch:main Jan 20, 2025
7 checks passed
@flevi29 flevi29 deleted the fix-vite-global-patch branch January 22, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants