You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose we remove this polyfill, users of this library can import a polyfill script for fetch (browser) (node) and the other stuff themselves in the few cases where they might still need to do so, and if they're targeting IE11, they already need to do this with URLhttps://github.com/lifaon74/url-polyfill. I believe polyfilling should be the responsibility of the final apps/websites.
#1656 is kind of a blocker for this, as removing cross-fetch would break tests, and that PR already fixes them.
The text was updated successfully, but these errors were encountered:
1688: Remove cross-fetch dependency r=brunoocasali a=flevi29
# Pull Request
## Related issue
Fixes#1658
## What does this PR do?
- removes `cross-fetch` dependency
- if anyone might need the polyfill they should run it themselves
- there's an interesting discussion [here](w3ctag/polyfills#6 (comment)) about polyfills in libraries; I think, as a lot of people do, that the sane and clean path ahead is to make it the responsibility of the library user to polyfill, even if it's somewhat of a burden
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
1698: Add `"packageManager"` entry to package.json r=brunoocasali a=flevi29
# Pull Request
## Why?
- [`corepack`](https://nodejs.org/docs/latest-v20.x/api/corepack.html) [started adding this field automatically](nodejs/corepack#413), which can be disabled, but everyone has to do it separately, which is very annoying
- anyhow there's no harm in it, `corepack` recommends it even in the "how to disable" doc https://github.com/nodejs/corepack/blob/main/README.md#environment-variables
- > it ensures that your project installs are always deterministic (if you use `corepack`)
- this does mean that this field will have to be updated periodically, but this is the recommended way
## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Co-authored-by: F. Levi <55688616+flevi29@users.noreply.github.com>
As detailed in #1610,
cross-fetch
isn't helping much. The only thing it does is usenode-fetch
on older Node.js versions.Also we are using two additional web standards that won't run on IE11 and we're not polyfilling:
meilisearch-js/src/http-requests.ts
Lines 129 to 138 in cd61a8c
I propose we remove this polyfill, users of this library can import a polyfill script for
fetch
(browser) (node) and the other stuff themselves in the few cases where they might still need to do so, and if they're targeting IE11, they already need to do this withURL
https://github.com/lifaon74/url-polyfill. I believe polyfilling should be the responsibility of the final apps/websites.#1656 is kind of a blocker for this, as removing
cross-fetch
would break tests, and that PR already fixes them.The text was updated successfully, but these errors were encountered: