Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: packet Cyclopedia house auction 13.40 #970

Merged
merged 24 commits into from
Jan 3, 2025
Merged

fix: packet Cyclopedia house auction 13.40 #970

merged 24 commits into from
Jan 3, 2025

Conversation

kokekanon
Copy link
Collaborator

@kokekanon kokekanon commented Nov 18, 2024 •
edited
Loading

fix packets , NO features (lua.otui) [I don't know what it is]

SEND Packet test lua - otui
sendCyclopediaHouseAuction 0xAD (173)
GET Packet test lua - otui
GameServerCyclopediaHouseAuctionMessage 0xC3 (195)
GameServerCyclopediaHousesInfo 0xC6 (198) ✅
GameServerCyclopediaHouseList 0xC7 (199)

Description

I was test. this pr opentibiabr/canary#3022

PR sent packets when logging

ERROR: ProtocolGame parse message exception (12336 bytes, 5967 unread, last opcode is 0xc6 (198), prev opcode is 0x9f (159)): unhandled opcode 198
Packet has been saved to packet.log, you can use it to find what was wrong. (Protocol: 1340)

I solved that problem, the rest is theoretical, I don't know how to test that.

last commits

26a2d60
"Merge branch 'main' into test-house"
on Nov 12, 2024, 02:28 PM

Behavior

Actual

Packet error

Expected

Do this and that happens

Fixes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

untest , until the end of the pr

Test Configuration:

  • Server Version: 13.40 26a2d60
  • Client: this PR
  • Operating System: 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

ONLY APPROVE IF PR CANARY # 3022 IS murge. if not close xd

kokekanon and others added 5 commits November 18, 2024 19:14
@kokekanon
fix: packet cyclopedia house auction Canary PR # 3022
47cb9dd 
last commits  26a2d60 "Merge branch 'main' into test-house"

 on Nov 12, 2024, 02:28 PM
@kokekanon
fix: Sonarbot string_view to string
06a34a3
@kokekanon
fix: sonar (Auto | Use the init-statement to declare "isOwner" inside…
c58eb8f 
… the if statement.)

-Use the init-statement to declare "isOwner" inside the if statement.
@kokekanon
fix: sonar Use the init-statement to declare "isRented" inside the if…
6ec2fe1 
… statement.
@Nottinghster
Merge branch 'main' into fix-warning
b3d9a41
luanluciano93
luanluciano93 previously requested changes Nov 25, 2024
View reviewed changes
src/client/game.cpp Outdated Show resolved Hide resolved
src/client/game.h Outdated Show resolved Hide resolved
src/client/protocolgame.h Outdated Show resolved Hide resolved
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
src/client/protocolgameparse.cpp Outdated Show resolved Hide resolved
src/client/protocolgamesend.cpp Outdated Show resolved Hide resolved
src/client/protocolgamesend.cpp Outdated Show resolved Hide resolved
src/client/protocolgamesend.cpp Outdated Show resolved Hide resolved
src/client/protocolgamesend.cpp Outdated Show resolved Hide resolved
src/client/protocolgamesend.cpp Outdated Show resolved Hide resolved
kokekanon and others added 16 commits November 25, 2024 13:10
@kokekanon @luanluciano93
Update src/client/protocolgame.h
48c9645 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/game.cpp
79fd222 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/game.h
d6bcada 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/protocolgameparse.cpp
7d4df98 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/protocolgameparse.cpp
55f6a1e 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/protocolgamesend.cpp
793c2d4 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/protocolgamesend.cpp
b9e1788 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/protocolgamesend.cpp
e41f07d 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/protocolgamesend.cpp
f5e8b40 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon @luanluciano93
Update src/client/protocolgamesend.cpp
2149b6f 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon
Merge branch 'main' into fix-warning
48c36c7
@kokekanon
Merge remote-tracking branch 'upstream/main' into fix-warning
b3a1691
@kokekanon
Merge remote-tracking branch 'upstream/main' into fix-warning
9aa5037
@Nottinghster
Merge branch 'main' into fix-warning
024c47b
@mehah
Merge branch 'main' into fix-warning
8c49c69
@kokekanon
Merge remote-tracking branch 'upstream/main' into fix-warning
98e0d65
@kokekanon kokekanon changed the title fix: packet Canary PR : "cyclopedia house auction" # 3022 fix: packet Cyclopedia house auction 13.40 Dec 31, 2024
@kokekanon kokekanon marked this pull request as ready for review December 31, 2024 18:44
@kokekanon @luanluciano93
Update src/client/protocolgameparse.cpp
8fa0219 
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
@kokekanon
Copy link
Collaborator Author

canary's pr # 3022 was approved today.

this pr can now be merged.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@majestyotbr majestyotbr merged commit 9ee23ba into mehah:main Jan 3, 2025
12 checks passed
vllworldbuilding pushed a commit to vllworldbuilding/otclient that referenced this pull request Jan 10, 2025
@kokekanon @vllworldbuilding
fix: packet Cyclopedia house auction 13.40 (mehah#970)
f5ce7ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majestyotbr majestyotbr majestyotbr approved these changes

@luanluciano93 luanluciano93 luanluciano93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kokekanon @luanluciano93 @majestyotbr @Nottinghster @mehah